Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: set volume backup failed if one data plane failed #5500

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Jan 5, 2024

What problem does this PR solve?

Make sure the VolumeBackup is failed after backup initialize failed.

Closes #5499

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge January 5, 2024 06:59
@ti-chi-bot ti-chi-bot bot added the size/S label Jan 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1e12427) 61.38% compared to head (979f64f) 61.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
- Coverage   61.38%   61.37%   -0.01%     
==========================================
  Files         234      234              
  Lines       29941    29947       +6     
==========================================
+ Hits        18378    18379       +1     
- Misses       9724     9727       +3     
- Partials     1839     1841       +2     
Flag Coverage Δ
unittest 61.37% <30.00%> (-0.01%) ⬇️

Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 09:34:31.994088119 +0000 UTC m=+349461.578341801: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 9, 2024
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc merged commit 7dc2d75 into pingcap:master Jan 9, 2024
6 of 13 checks passed
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5508.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup stuck when backup pod can't be scheduled
5 participants